add script to out put list of files containing linting errors#1997
Conversation
jng34
left a comment
jng34
left a comment
There was a problem hiding this comment.
@angela-lee1 The script works as expected; lint report and files count were generated.
|
@angela-lee1 The script looks good! Could you add |
|
Thank you, @bconti123! I will take a look at it. |
|
Add the following entries to After that, I’ll approve the PR and it should be good to go. |
|
@bconti123, will do! ETA ETD 1/31. Thanks. |
|
Hey @angela-lee1, just checking in. Are you still planning to make the requested changes? |
This reverts commit e2cb492. revert the commit to remove the lint json and txt file
- Rename list-lint-files.js to list-lint-files.mjs - Remove "type": "module" from package.json (breaks CommonJS backend) - Update npm script to use .mjs extension The .mjs extension enables ES modules for just this script without affecting the rest of the project.
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Review: Approve
Summary: Adds script to list files with linting errors.
Fix Applied
Changed approach from "type": "module" to .mjs extension:
- ❌
"type": "module"would break entire project (backend uses CommonJS) - ✅
.mjsextension enables ES modules for just this script
Changes
- Renamed
list-lint-files.js→list-lint-files.mjs - Removed
"type": "module"from package.json - Updated npm script path
Script works correctly. Ready to merge.
trillium
force-pushed
the
create-script-output-list-files-containing-linting-errors
branch
from
4a5f51c to
3ebeb6c
Compare
…ining-linting-errors
4 participants
Fixes #1968
What changes did you make and why did you make them?
"To streamline linting remediation across the VRMS codebase, we need a script that outputs a list of files with linting errors. This will help prioritize fixes and track progress, and align work across team members."
"lint:files": "node scripts/list-lint-files.js"in the package.json